Browse Source

Use a better OlderThan for DeleteInactiveUsers (#19693)

* Use a better OlderThan for DeleteInactiveUsers

- Currently the OlderThan is zero, for instances that enable or run this
task this could actually delete just new users that still need to
confirm their email. This patch fixes that by setting the default to the
`ActiveCodeLives` setting, which corresponds to the amount of time that
a user can active their account, thus avoiding the issue of deleting
unactivated email users.

* Use correct duration
pull/19702/head
Gusted 1 week ago committed by GitHub
parent
commit
61f939359d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      services/cron/tasks_extended.go

2
services/cron/tasks_extended.go

@ -26,7 +26,7 @@ func registerDeleteInactiveUsers() { @@ -26,7 +26,7 @@ func registerDeleteInactiveUsers() {
RunAtStart: false,
Schedule: "@annually",
},
OlderThan: 0 * time.Second,
OlderThan: time.Minute * time.Duration(setting.Service.ActiveCodeLives),
}, func(ctx context.Context, _ *user_model.User, config Config) error {
olderThanConfig := config.(*OlderThanConfig)
return user_service.DeleteInactiveUsers(ctx, olderThanConfig.OlderThan)

Loading…
Cancel
Save